I am trying to create a form accesible with a menu in Virtuoso Layout editor to create a complex shape. Managed to add the menu, couple of menu items and create a form using material in this forum and web but struggling to pass the values input through the form to a procedure. I am trying to draw a donutas a start.
My code is copied below and appriciate anyone can help figuring out the problem.
The error message is
*Error* dbCreateDonut argument #4 should be a number (type template = "dglnn") - nil
procedure(CreateAddDoForm() let((InnerRadius OuterRadius Centre Layer) InnerRadius=hiCreateIntField( ?name 'InnerRadius ?prompt "Inner Radius" ) OuterRadius=hiCreateIntField( ?name 'OuterRadius ?prompt "Outer Radius" ) Centre=hiCreateIntField( ?name 'Centre ?prompt "Centre" ) Layer=hiCreateIntField( ?name 'Layer ?prompt "Layer" ) hiCreateAppForm( ?name 'AddDonutForm ?formTitle "Input Source Parameters" ?buttonLayout 'OKCancelApply ?callback "DrawDonut()" ?fields list( list(InnerRadius 0:0 200:30 100) list(OuterRadius 0:35 200:30 100) list(Centre 0:70 200:30 100) list(Layer 0:105 200:30 100) ) ) );let );procedureprocedure(FunctionAddDonut() unless(boundp('AddDonutForm) CreateAddDoForm() ) hiDisplayForm(AddDonutForm) )procedure(DrawDonut() let( (Orad Irad) Orad=AddDonutForm->OuterRadius->Value Irad=AddDonutForm->InnerRadius->Value cvID=geGetWindowCellView() dbCreateDonut(cvID "DIFF" 0:0 Orad Irad) ) )
In your DrawDonut function, the ->Value should be ->value (it is case sensitive):
procedure(DrawDonut() let( (Orad Irad) Orad=AddDonutForm->OuterRadius->value Irad=AddDonutForm->InnerRadius->value cvID=geGetWindowCellView() dbCreateDonut(cvID "Metal2" 0:0 Orad Irad) ) )
In reply to Andrew Beckett:
Superb Andrew! Many thanks.
Can I ask one more question please....
I am trying to chop a donut into peices with leChopShape so that I can remove pieces of the donut. In the following code I wrote, it works for couple of i s and doesn't do it all the way around the donut.
I checked whether the logic is working with the commented out dbCreateLine statement which seem to draw the line as I want it.
I was wondering whether the db ID of the shape is changed when it is chopped and tried get the handle with "NewShapes" but didn't quite work.
Appriciate of you can help.
Try the ConstructCog(100 2 1 1 2) to invoke it.
Many thanks again.
procedure( ConstructCog(cc_mainR cc_SourceNLength cc_NPolyOvelap cc_NWidth cc_PWidth) MainCirc= 2*3.14*cc_mainR NumOfSegs=round(MainCirc/(cc_NWidth+cc_PWidth)) SegWidth=MainCirc/NumOfSegs SegNWidth=SegWidth*cc_NWidth/(cc_NWidth+cc_PWidth) cc_InnerR=cc_mainR-cc_NPolyOvelap cc_OuterR=cc_mainR+cc_SourceNLength cvID=geGetWindowCellView() donutID=dbCreateDonut(cvID "NPLUS" 0:0 cc_OuterR cc_InnerR) ;hiZoomAbsoluteScale(cvID 1) ; want to zoom to fit, doesn't work NSegAngle=SegNWidth/cc_mainR PitchAngle=SegWidth/cc_mainR cc_TempRadius=cc_mainR+cc_SourceNLength+1for(i 1 NumOfSegs i_FirstX=cc_TempRadius*cos((i-1)*PitchAngle) i_FirstY=cc_TempRadius*sin((i-1)*PitchAngle) i_secondX=cc_TempRadius*cos((i-1)*PitchAngle+NSegAngle) i_secondY=cc_TempRadius*sin((i-1)*PitchAngle+NSegAngle) ;dbCreateLine(cvID "PPLUS" list(0:0 i_FirstX:i_FirstY i_secondX:i_secondY 0:0))
;leChopShape( donutID list(0:0 i_FirstX:i_FirstY i_secondX:i_secondY 0:0) nil nil 300 ) NewShapes=leChopShape( donutID list(0:0 i_FirstX:i_FirstY i_secondX:i_secondY 0:0) nil nil 300 ) donutID=cadr(NewShapes) );for ) ;procedure
In reply to NKU10k:
The problem is that leChopShape will return a list of the new shapes - and you have no idea which is the one you want to do subsequent chops on. Now you're not removing the gaps you're chopping out (I suspect you want to though) - but even if you do that, it's not going to solve the problem - fundamentally you will end up with two or three shapes when you chop the remainder of the donut (depending on whether you keep the shapes in the chopped region). If you pick the wrong shape (you have arbitrarily chosen then cadr), then the next chop will return nil because there was nothing that was chopped.
So I think you need to do something like the below - use dbGetTrueOverlaps to find the polygon underneath the mid point of the next segment to be chopped (I compute the midRadius and then a point half way through that segment) - and then chop that. In this example I also remove the chopped region (you must tell it that the chop points are a closed polygon for that to work) - whether you want to do that or not is up to you (this is the t t arguments in leChopShape).
I also added local variables too, for good measure. Note that in the code, you might be able to use cc_mainR rather than computing cc_midRadius (I'll leave that to you - I only spotted this upon reviewing the code).
Thanks Andrew. This is very very helpful.
Will save days!!