Rename label and part of instance in multiple layouts

You have a lot of questions, so I highly recommend you read some Skill documentation. I am including some "untested" skill code. It should be almost ready to run. You should take a look at what I have done and look at some documentation to make sure you understand it. Your description of what you wanted is somewhat vague. It is unclear to me if "xxx", "yyy" and "zzz" are literal, or if wildcard matching is necessary. I assumed wildcards since that is the more complicated scenario. If the names are literal, then a simple == comparison is all that is needed in the check rather than a rexMatchp. Also, if it is literal, then you could skip the rexReplace and rexCompile commands altogether and do simple string assignments.

I broke the code into a routine that runs on a cellview. This makes code testing easier. Run the "changeCell" routine on the current open layout cellview to make sure your labels and cellview are change appropriately. Since the save takes place in the calling routine, you can discard your edits, adjust the code and retest. If you change the value of the badLibrary in the optional arguments to whatever you are referring to in #3, then you can actually run "changeCell()" with no arguments and it will get the current open cellview and use the bad library name that you wish to check for.

;You must define myLibary and badRefLibrary

procedure(doAllCells(myLibrary badRefLibrary)
  let((libId cv)
    libId = ddGetObj(myLibrary)
    foreach(cell libId~>cells~>name
        when(ddGetObj(myLibrary cell "layout")
            printf("Working on cell %s\n" cell)
            cv = dbOpenCellViewByType(myLibrary cell "layout" nil "a")
            changeCellView(cv badRefLibrary)
            dbSave(cv)
            dbClose(cv)
        )
    )
  ) ;let
) ;proc

procedure(changeCellView(@optional (cv geGetEditCellView()) (badRefLibrary "myBadLibrary"))
  let((labels newLabel insts cellName newCellName badRefs)
    labels = setof(x cv~>shapes x~>objType=="label")
    rexCompile("AB")
    foreach(lbl labels
        ;If only replacing labels that are currently m1 then use this when statement
        when(lbl~>lpp == list("m1" "drawing")
            newLabel = rexReplace(lbl~>theLabel "CD" 0)
            lbl~>theLabel = newLabel
        )
        ;OR if wanting to convert the label to m1, use this
        lbl~>lpp = list("m1" "drawing")
    )

    insts = setof(x cv~>instances x~>libName == "YYYY" && rexMatchp("AB" x~>cellName))
    foreach(inst insts
        cellName = inst~>cellName
        rexCompile("yyy")
        newCellName = rexReplace(cellName "zzz" 0)
        rexCompile("AB")
        newCellName = rexReplace(newCellName "CD" 0)
        leReplaceAnyInstMaster(inst "ZZZZ" newCellName nil)
    )

    ;You must specify badRefLibrary
    badRefs = setof(x cv~>instances x~>libName == badRefLibrary)
    when(badRefs
        foreach(r badRefs
            printf("**ERROR: Found reference from library %s in %s\n" badRefLibrary r~>cellName)
        )
    )
  ) ;let
) ;proc

-Derek

You have a lot of questions, so I highly recommend you read some Skill documentation. I am including some "untested" skill code. It should be almost ready to run. You should take a look at what I have done and look at some documentation to make sure you understand it. Your description of what you wanted is somewhat vague. It is unclear to me if "xxx", "yyy" and "zzz" are literal, or if wildcard matching is necessary. I assumed wildcards since that is the more complicated scenario. If the names are literal, then a simple == comparison is all that is needed in the check rather than a rexMatchp. Also, if it is literal, then you could skip the rexReplace and rexCompile commands altogether and do simple string assignments.

I broke the code into a routine that runs on a cellview. This makes code testing easier. Run the "changeCell" routine on the current open layout cellview to make sure your labels and cellview are change appropriately. Since the save takes place in the calling routine, you can discard your edits, adjust the code and retest. If you change the value of the badLibrary in the optional arguments to whatever you are referring to in #3, then you can actually run "changeCell()" with no arguments and it will get the current open cellview and use the bad library name that you wish to check for.

;You must define myLibary and badRefLibrary

procedure(doAllCells(myLibrary badRefLibrary)
  let((libId cv)
    libId = ddGetObj(myLibrary)
    foreach(cell libId~>cells~>name
        when(ddGetObj(myLibrary cell "layout")
            printf("Working on cell %s\n" cell)
            cv = dbOpenCellViewByType(myLibrary cell "layout" nil "a")
            changeCellView(cv badRefLibrary)
            dbSave(cv)
            dbClose(cv)
        )
    )
  ) ;let
) ;proc

procedure(changeCellView(@optional (cv geGetEditCellView()) (badRefLibrary "myBadLibrary"))
  let((labels newLabel insts cellName newCellName badRefs)
    labels = setof(x cv~>shapes x~>objType=="label")
    rexCompile("AB")
    foreach(lbl labels
        ;If only replacing labels that are currently m1 then use this when statement
        when(lbl~>lpp == list("m1" "drawing")
            newLabel = rexReplace(lbl~>theLabel "CD" 0)
            lbl~>theLabel = newLabel
        )
        ;OR if wanting to convert the label to m1, use this
        lbl~>lpp = list("m1" "drawing")
    )

    insts = setof(x cv~>instances x~>libName == "YYYY" && rexMatchp("AB" x~>cellName))
    foreach(inst insts
        cellName = inst~>cellName
        rexCompile("yyy")
        newCellName = rexReplace(cellName "zzz" 0)
        rexCompile("AB")
        newCellName = rexReplace(newCellName "CD" 0)
        leReplaceAnyInstMaster(inst "ZZZZ" newCellName nil)
    )

    ;You must specify badRefLibrary
    badRefs = setof(x cv~>instances x~>libName == badRefLibrary)
    when(badRefs
        foreach(r badRefs
            printf("**ERROR: Found reference from library %s in %s\n" badRefLibrary r~>cellName)
        )
    )
  ) ;let
) ;proc

-Derek