changing layer names

This is a little odd. Typically "cv" is a variable used to refer to a cellView object which won't have a layerName attribute. Also, the layerName attribute is a string, not a list. What you are showing here seems to indicate that cv is a list of two shapes and temp is a list of the layerNames you want to assign to the two shapes. When you run cv~>layerName="M1", you are assigning "M1" to every object in the list stored in cv. So I can only guess that you either want to swap layerNames on two shapes, or, for some list of shapes you want to apply some list of layerNames. The following will work if the list of shapes is the same length as the list of layer names:

;I will use your same variable names although I suggest you use something other than cv for a list of shapes
foreach((shape layName) cv temp
  shape~>layerName = layName
)

This foreach statement loops through two lists at the same time. Each time through the loop, an item from "cv" is assigned to the variable "shape" and a layer name from the list "temp" is assigned to the variable "layName".

Derek

Hi Derek,

This is a part of code used to change metal layers with bindkeys and with your help with foreach loop, it is in working mode.

I am new to coding . Attached is the code . Further fix required is its considering first db id . Example if I selected M0 and M1 (in this order) and use down(), It won't change M1 to M0  (M0 is lowest layer)

procedure(up()

cv=geGetSelectedSet()
let((ln1)
temp=list(0)
foreach(ln (cv~>layerName) 
case(ln
("M0" ln1="M1")
("M1" ln1="M2")
("M2" println("Already top metal"))
);case
temp=cons(ln1 temp)
);foreach
a=cdr(reverse(temp))
);let
foreach((old new) cv a
old~>layerName=new
);foreach
);procedure

procedure(down()
cv=geGetSelectedSet()
let((ln1)
temp=list(0)
foreach(ln (cv~>layerName) 
case(ln
("M1" ln1="M0")
("M2" ln1="M1")
("M0" println("Already bottom metal"))
);case
temp=cons(ln1 temp)
);foreach
a=cdr(reverse(temp))
);let
foreach((old new) cv a
old~>layerName=new
);foreach
);procedure

hiSetBindKey("Layout" "Ctrl<Key>5"  "up()")
hiSetBindKey("Layout" "Ctrl<Key>6"  "down()

You've made the code rather complicated - I don't see any good reason why you loop over the shapes twice. Also, using "cv" as a variable for a shape is rather confusing... Something like this would be clearer and more concise (and would solve your problem):

procedure(CCFup()
  let((newLayer)
    foreach(fig geGetSelectedSet()
      newLayer=case(fig~>layerName
        ("M0" "M1")
        ("M1" "M2")
      )
      when(newLayer
        fig~>layerName=newLayer
      )
    )
   t
  )
)

I'm sure you can rewrite the down version using a similar approach (note, I didn't test this - but should work). It doesn't print a message when the limit is reached - it just silently doesn't change it. That's because the case() function returns nil in that case, as it would if it wasn't a shape, and the layer name is only updated if it got a new layer.

Regards,

Andrew.

 Thanks Andrew and dmay .

It is working now . :0