• Skip to main content
  • Skip to search
  • Skip to footer
Cadence Home
  • This search text may be transcribed, used, stored, or accessed by our third-party service providers per our Cookie Policy and Privacy Policy.

  1. Community Forums
  2. Custom IC SKILL
  3. nconc with (back)quote'd list constants

Stats

  • Locked Locked
  • Replies 11
  • Subscribers 144
  • Views 4492
  • Members are here 0
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

nconc with (back)quote'd list constants

tweeks
tweeks over 11 years ago

Google says: "Avoid nconc!"

http://google-styleguide.googlecode.com/svn/trunk/lispguide.xml#Avoid_NCONC

They recommend to use "mappend" instead, which you could naively define this way (naive because it's O(n^2)!):

(defun mappend (fn list "ul")
  "Append the results of calling fn on each element of list.
  Like mapcan, but uses append instead of nconc."
  (foldl1 append (mapcar fn list)))

(defun foldl1 (function list "ul")
  (if (null list)
      (error "foldl1: empty list")
      (foldl function (car list) (cdr list))))

(defun foldl (function initial list "ugl")
  (let ((result initial))
    (foreach mapc element list
      (setq result (function result element)))
    result))

If you don't see the danger, try this:

ILS-> (mappend (lambda (x) '(t)) '(1 2 3))
(t t t)
ILS-> (mapcan (lambda (x) '(t)) '(1 2 3))

The mappend version works correctly, but the mapcan version sends the interpreter into an infinite loop! 

Explanation: mapcan applies the lambda to 1, and nconcs the result--the constant '(t) list returned by the lambda--to itself, resulting in a circular list of length one, where the car is t and the cdr is its own car.  The next iteration, mapcan applies the lambda to 2, only this time nconc never returns, because it's too busy trying to find the end of an endless list....

I guess I'll have to write my own (foreach mappend....) to use in place of the more dangerous (foreach mapcan...).

  • Cancel
Parents
  • Andrew Beckett
    Andrew Beckett over 11 years ago

    Tom,

    I just took a look in the source code, and actually it's effectively using tconc. It keeps a structure like a tconc inside - in other words, a pointer to the beginning of the list, and a pointer to the last cons cell. This is all done in the virtual machine rather than using tconc itself.

    I suspect that the manual describes it in terms of nconc because there's no external visibility of the tconc and that might confuse people. However, the wording suggesting that it's using nconc might lead you to suspect that it has the efficiency (or rather inefficiency) of nconc.

    I filed CCR 1318514 to make the documentation a bit more truthful!

    Regards,

    Andrew.

     

    • Cancel
    • Vote Up 0 Vote Down
    • Cancel
Reply
  • Andrew Beckett
    Andrew Beckett over 11 years ago

    Tom,

    I just took a look in the source code, and actually it's effectively using tconc. It keeps a structure like a tconc inside - in other words, a pointer to the beginning of the list, and a pointer to the last cons cell. This is all done in the virtual machine rather than using tconc itself.

    I suspect that the manual describes it in terms of nconc because there's no external visibility of the tconc and that might confuse people. However, the wording suggesting that it's using nconc might lead you to suspect that it has the efficiency (or rather inefficiency) of nconc.

    I filed CCR 1318514 to make the documentation a bit more truthful!

    Regards,

    Andrew.

     

    • Cancel
    • Vote Up 0 Vote Down
    • Cancel
Children
No Data

Community Guidelines

The Cadence Design Communities support Cadence users and technologists interacting to exchange ideas, news, technical information, and best practices to solve problems and get the most from Cadence technology. The community is open to everyone, and to provide the most value, we require participants to follow our Community Guidelines that facilitate a quality exchange of ideas and information. By accessing, contributing, using or downloading any materials from the site, you agree to be bound by the full Community Guidelines.

© 2025 Cadence Design Systems, Inc. All Rights Reserved.

  • Terms of Use
  • Privacy
  • Cookie Policy
  • US Trademarks
  • Do Not Sell or Share My Personal Information