Menu creation in Explorer

Salut Laurent,

I think that's quite OK as you are setting the session variable but you don't reference it in the rest of the code...

You are fetching the window from the DPL that is passed as your trigger's argument so I guess you will always get the one you want.

But the way you fetch the banner menu might cause trouble : 

If you have another banner menu called Setup your submenu might be placed at the wrong position

Also you can always replace (car (setof ...)) in your codes by (car (exists ...)) to improve runtime and avoid completely parsing lists when you can stop earlier.

You can also use (lsprintf ...) instead of (sprintf nil ...) but this is just syntactic sugar

And for safety, in case your trigger is called two times in the same window, you might add a check to make sure the submenu does not exists already

(although it might be ok because your submenu name is fixed, but it should print a warning)

Hope this helps,

Cheers

Aurélien

Salut Laurent,

I think that's quite OK as you are setting the session variable but you don't reference it in the rest of the code...

You are fetching the window from the DPL that is passed as your trigger's argument so I guess you will always get the one you want.

But the way you fetch the banner menu might cause trouble : 

If you have another banner menu called Setup your submenu might be placed at the wrong position

Also you can always replace (car (setof ...)) in your codes by (car (exists ...)) to improve runtime and avoid completely parsing lists when you can stop earlier.

You can also use (lsprintf ...) instead of (sprintf nil ...) but this is just syntactic sugar

And for safety, in case your trigger is called two times in the same window, you might add a check to make sure the submenu does not exists already

(although it might be ok because your submenu name is fixed, but it should print a warning)

Hope this helps,

Cheers

Aurélien

Thanks Aurélien for the tricks ;)

This is the kind of check you should add around adding the menu. Normally you add menus in the userMenuTrigger  but in this case it's modifying an existing menu, so you really have to do that in the userPostInstallTrigger. I don't think the trigger gets called more than once in ADE (you don't have the issue with descending/ascending hierarchy), and also the pulldown menus are unique per Explorer window, but it's good practice to add the check around the code.

(deRegUserTriggers "explorer" nil nil 'customMenusInExplorer)

(defun customMenusInExplorer (largs)
  (let (wid session s_setupMenu submenu1)
    (setq wid (getq largs window))
    (setq session (getq wid sevSession))
    (setq s_setupMenu
	  (car (setof x (hiGetBannerMenus wid) (pcreMatchp "Set[&]?up" (getq (eval x) _menuTitle)))))
    (unless (getq (symeval s_setupMenu) sliderCustomMenu)
      (setq submenu1
	    (hiCreatePulldownMenu 'submenu1
				  "submenu1"
				  (list (hiCreateMenuItem ?name 'subsubmenu1
							  ?itemText "subsubmenu1"
							  ?callback (sprintf nil "(CBsubsubmenu1 '%L)" ,session))
					(hiCreateMenuItem ?name 'subsubmenu2
							  ?itemText "subsubmenu2"
							  ?callback (sprintf nil "(CBsubsubmenu2'%L)" ,session)))))
      (hiAddMenuItem (symeval s_setupMenu) (hiCreateSliderMenuItem ?name 'sliderCustomMenu ?itemText "Custom Menu" ?subMenu submenu1))
      )
    ) ; let
  ) ; defun

Andrew

thank you