ADE Assembler: variable values with leading zeros interpreted as octal in ICADVM20.1

Thank you all for your replies. Interesting situation to say the least! (I wonder about the origins of the idea of using "0" as a prefix for octal--never heard of that before in my entire career!)

I guess we'll have to explore the solution of automatically updating it via skill, but that will be a problem for "future Jorge". For the time being I guess we'll have to update manually on a per-case basis...

Cheers,

Jorge.

Hi Jorge,

The C language also treats literal integers which start with a 0 as octal, so it's not unique to SKILL. Of course, most designers would not necessarily expect this - in the same way that designers get confused by the fact that 1/2 in expressions is 0!

I wrote some code that I think will do the job of the cleanup. Caveat emptor, since I've really not done a huge amount of testing - you might want to try using abCleanOctalLikeNumbersInVars() on an open session or two before trying abRegOctalLikeNumbers() to do it automatically when a maestro view is opened (if you really want that). Hopefully I got the regular expression right!

Regards,

Andrew

/* abCleanOctalLikeNumbers.il

Author     A.D.Beckett
Group      Custom IC (UK), Cadence Design Systems Ltd.
Language   SKILL
Date       Apr 01, 2021 
Modified   
By         

Provide functions to clean up numbers that will be interpreted
in SKILL as octal, even though that wasn't what the designer intended

abCleanOctalLikeNumbersInVars([session]
    cleans up all design and global variables in the given (or current)
    ADE XL/Explorer/Assembler session

abRegCleanOctalLikeNumbers()
    registers a trigger to do the cleanup whenever a maestro or adexl
    view is opened. Use once you're happy it works properly (I
    have only done limited testing)

***************************************************

SCCS Info: @(#) abCleanOctalLikeNumbers.il 04/02/21.10:25:24 1.2

*/

/************************************************************************
*                                                                       *
*                  abCleanOctalLikeNumbers(expression)                  *
*                                                                       *
* Take a string expression, and replace any number that starts with a 0 *
* so that it doesn't start with a number any more. This avoids numbers  *
*              starting with 0 as being treated as octal.               *
*                                                                       *
************************************************************************/

procedure(abCleanOctalLikeNumbers(expression)
    ;--------------------------------------------------------------------
    ; pattern looks for a non-word non-dot character, followed by one 
    ; or more zeros, followed by one or more digits
    ;--------------------------------------------------------------------
    let(((pat pcreCompile("(^|[^\\w.])0+(\\d+)")))
        if(stringp(expression) && pcreExecute(pat expression) then
            pcreReplace(pat expression "\\1\\2" 0)
        else
            expression
        )
    )
)

/***********************************************************************
*                                                                      *
*                abCleanOctalLikeNumbersForHandle(sdb)                 *
*                                                                      *
*   Passed either a handle for the whole view (for global variables)   *
* or for a test (for design variables) and iterates over all variables *
*        and tries cleaning them up to avoid octal-like values         *
*                                                                      *
***********************************************************************/

procedure(abCleanOctalLikeNumbersForHandle(sdb)
    let((var curValue newValue)
        foreach(varName cadr(axlGetVars(sdb))
            var=axlGetVar(sdb varName)
            curValue=axlGetVarValue(var)
            newValue=abCleanOctalLikeNumbers(curValue)
            unless(newValue==curValue
                printf("Changing Expression %s to %s\n" curValue newValue)
                axlPutVar(sdb varName newValue)
            )
        )
        t
    )
)

/***************************************************************
*                                                              *
*           abCleanOctalLikeNumbersInVars([session])           *
*                                                              *
*     Fixes all the octal-like numbers in a given session      *
*                 (defaults to current window)                 *
*                                                              *
***************************************************************/

procedure(abCleanOctalLikeNumbersInVars(
        @optional (session axlGetWindowSession()))
    let((sdb test)
        sdb=axlGetMainSetupDB(session)
        abCleanOctalLikeNumbersForHandle(sdb)
        foreach(testName cadr(axlGetTests(sdb))
            test=axlGetTest(sdb testName)
            abCleanOctalLikeNumbersForHandle(test)
        )
        t
    )
)

/***************************************************************
*                                                              *
*           abRegCleanOctalLikeNumbersInit(session)            *
*                                                              *
*   Registers a trigger to do the cleanup once the UI is up    *
*                                                              *
***************************************************************/

procedure(abRegCleanOctalLikeNumbersInit(session)
    axlSessionConnect(session "postInstall" 'abCleanOctalLikeNumbersInVars)
)

/***************************************************************
*                                                              *
*                 abRegCleanOctalLikeNumbers()                 *
*                                                              *
*   Registers the postInstall trigger at startup of the view   *
*                                                              *
***************************************************************/

procedure(abRegCleanOctalLikeNumbers()
    axlSessionRegisterCreationCallback('abRegCleanOctalLikeNumbersInit)
)

/***************************************************************
*                                                              *
*                abTestCleanOctalLikeNumbers()                 *
*                                                              *
*            Test code to check for a few examples             *
*                                                              *
***************************************************************/

procedure(abTestCleanOctalLikeNumbers()
    assert(abCleanOctalLikeNumbers("0123")=="123")
    assert(abCleanOctalLikeNumbers("(0562+0*012)/073^02")=="(562+0*12)/73^2")
    assert(abCleanOctalLikeNumbers("TRIM_024_VAL+014")=="TRIM_024_VAL+14")
    assert(abCleanOctalLikeNumbers("0.0033")=="0.0033")
    assert(abCleanOctalLikeNumbers("if( 012==12 0515 0632 )")==
        "if( 12==12 515 632 )")
    t
)

Hi Jorge,

The C language also treats literal integers which start with a 0 as octal, so it's not unique to SKILL. Of course, most designers would not necessarily expect this - in the same way that designers get confused by the fact that 1/2 in expressions is 0!

I wrote some code that I think will do the job of the cleanup. Caveat emptor, since I've really not done a huge amount of testing - you might want to try using abCleanOctalLikeNumbersInVars() on an open session or two before trying abRegOctalLikeNumbers() to do it automatically when a maestro view is opened (if you really want that). Hopefully I got the regular expression right!

Regards,

Andrew

/* abCleanOctalLikeNumbers.il

Author     A.D.Beckett
Group      Custom IC (UK), Cadence Design Systems Ltd.
Language   SKILL
Date       Apr 01, 2021 
Modified   
By         

Provide functions to clean up numbers that will be interpreted
in SKILL as octal, even though that wasn't what the designer intended

abCleanOctalLikeNumbersInVars([session]
    cleans up all design and global variables in the given (or current)
    ADE XL/Explorer/Assembler session

abRegCleanOctalLikeNumbers()
    registers a trigger to do the cleanup whenever a maestro or adexl
    view is opened. Use once you're happy it works properly (I
    have only done limited testing)

***************************************************

SCCS Info: @(#) abCleanOctalLikeNumbers.il 04/02/21.10:25:24 1.2

*/

/************************************************************************
*                                                                       *
*                  abCleanOctalLikeNumbers(expression)                  *
*                                                                       *
* Take a string expression, and replace any number that starts with a 0 *
* so that it doesn't start with a number any more. This avoids numbers  *
*              starting with 0 as being treated as octal.               *
*                                                                       *
************************************************************************/

procedure(abCleanOctalLikeNumbers(expression)
    ;--------------------------------------------------------------------
    ; pattern looks for a non-word non-dot character, followed by one 
    ; or more zeros, followed by one or more digits
    ;--------------------------------------------------------------------
    let(((pat pcreCompile("(^|[^\\w.])0+(\\d+)")))
        if(stringp(expression) && pcreExecute(pat expression) then
            pcreReplace(pat expression "\\1\\2" 0)
        else
            expression
        )
    )
)

/***********************************************************************
*                                                                      *
*                abCleanOctalLikeNumbersForHandle(sdb)                 *
*                                                                      *
*   Passed either a handle for the whole view (for global variables)   *
* or for a test (for design variables) and iterates over all variables *
*        and tries cleaning them up to avoid octal-like values         *
*                                                                      *
***********************************************************************/

procedure(abCleanOctalLikeNumbersForHandle(sdb)
    let((var curValue newValue)
        foreach(varName cadr(axlGetVars(sdb))
            var=axlGetVar(sdb varName)
            curValue=axlGetVarValue(var)
            newValue=abCleanOctalLikeNumbers(curValue)
            unless(newValue==curValue
                printf("Changing Expression %s to %s\n" curValue newValue)
                axlPutVar(sdb varName newValue)
            )
        )
        t
    )
)

/***************************************************************
*                                                              *
*           abCleanOctalLikeNumbersInVars([session])           *
*                                                              *
*     Fixes all the octal-like numbers in a given session      *
*                 (defaults to current window)                 *
*                                                              *
***************************************************************/

procedure(abCleanOctalLikeNumbersInVars(
        @optional (session axlGetWindowSession()))
    let((sdb test)
        sdb=axlGetMainSetupDB(session)
        abCleanOctalLikeNumbersForHandle(sdb)
        foreach(testName cadr(axlGetTests(sdb))
            test=axlGetTest(sdb testName)
            abCleanOctalLikeNumbersForHandle(test)
        )
        t
    )
)

/***************************************************************
*                                                              *
*           abRegCleanOctalLikeNumbersInit(session)            *
*                                                              *
*   Registers a trigger to do the cleanup once the UI is up    *
*                                                              *
***************************************************************/

procedure(abRegCleanOctalLikeNumbersInit(session)
    axlSessionConnect(session "postInstall" 'abCleanOctalLikeNumbersInVars)
)

/***************************************************************
*                                                              *
*                 abRegCleanOctalLikeNumbers()                 *
*                                                              *
*   Registers the postInstall trigger at startup of the view   *
*                                                              *
***************************************************************/

procedure(abRegCleanOctalLikeNumbers()
    axlSessionRegisterCreationCallback('abRegCleanOctalLikeNumbersInit)
)

/***************************************************************
*                                                              *
*                abTestCleanOctalLikeNumbers()                 *
*                                                              *
*            Test code to check for a few examples             *
*                                                              *
***************************************************************/

procedure(abTestCleanOctalLikeNumbers()
    assert(abCleanOctalLikeNumbers("0123")=="123")
    assert(abCleanOctalLikeNumbers("(0562+0*012)/073^02")=="(562+0*12)/73^2")
    assert(abCleanOctalLikeNumbers("TRIM_024_VAL+014")=="TRIM_024_VAL+14")
    assert(abCleanOctalLikeNumbers("0.0033")=="0.0033")
    assert(abCleanOctalLikeNumbers("if( 012==12 0515 0632 )")==
        "if( 12==12 515 632 )")
    t
)

Hi Jorge,

I updated the code I posted yesterday - so don't use the code in any email notification from yesterday; use the latest code in the thread above (I replaced it in the post with version 1.2 to avoid having two versions in the thread). I suddenly realised (in the middle of the night, as you do) that it would rather unhelpfully "clean" floating point numbers that had zeros (e.g. "0.0012" would have become "0.12", which is clearly wrong). Hopefully there aren't other issues (other than I know it will still remove leading zeros in numbers inside double quotes within the expression - I decided that was fairly unlikely to happen and probably not worth the complexity of trying to deal with).

Andrew