Undo history cleared when saving layout

There's a cdsenv var that controls this, which was introduced in IC616. 

envSetVal("cdba.undo" "dbUndoAcrossSave" 'boolean t)

For more details, see: Need a way to undo even after the save and purge command in Virtuoso

Regards,

Andrew

Hi Andrew,

Thanks for your response.

Actually the env variable worked very well to undo, just the concern that the save button is disabled after using undo.
there is a workaround  (CCScustomUndoSave.il) about it that ask if you want to save in a separated window, but I need to enable the button.

Just in case, I've tried to modify the enabled condition on the toolbar manager and accessing the icon properties modifying this code, but no luck.

procedure(CCSDisableCheckAndSave(args)
let( (win bannerMenus FileMenu FileMenuItems SaveMenuItem barId )
win=args->window
bannerMenus=hiGetBannerMenus(win)
FileMenu=nth(1 bannerMenus)
FileMenuItems=hiGetMenuItems(eval(FileMenu))
SaveMenuItem=nth(8 FileMenuItems)
hiDisableMenuItem(eval(FileMenu) CheckAndSaveMenuItem win)

;; Section to change the Check And Save toolbar action
;; Get the toolbar id of the File toolbar
barId = car(
setof(menu hiGetWindowToolbars( hiGetSessionWindow(hiGetCurrentWindow()) )
rexMatchp("^leFileToolbar" symbolToString(menu~>hiToolbarManager));schFileToolbar para schematico
) ;setof
) ;car

;; SKILL function - deFindToolbar has been made available since IC615ISR7.
;; Starting IC615ISR7, to get toolbar id of the File toolbar, we can instead call
;; barId = deFindToolbar( "File" hiGetSessionWindow( win))

;; Delete the default toolbar;checa que sea la correcta, checando que el callback sea el mismo
if(barId->leFileToolbarSave->hiCallback=="leHiSave()" then
hiDeleteToolbarItem( barId 'leFileToolbarSave)
) ;if

);let
);procedure CCSDisableCheckAndSave

deRegUserTriggers("maskLayout" nil nil 'CCSDisableCheckAndSave)
deRegUserTriggers("maskLayoutXL" nil nil 'CCSDisableCheckAndSave)

Unfortunately the issue is that the enabled status of the save icon is updated automatically based on whether the cellView is marked as modified.  Undoing past the last save will initially show the database as modified, but if you undo back to the previous saved state, then the database is considered unmodified (whereas it is really modified with respect to what's on disk).

Attempts to change the toolbar enabled status will fail because the triggers will immediately update it again. The only way around this would be to create a new toolbar which then wouldn't update - and that's not really a viable option.

Until CCR 2437856 is fixed, I think the only real workaround is that in the article. I suggest you contact customer support and request a duplicate is filed on your behalf.

Andrew

I did a little further experiment, and in fact this draws me to the conclusion that fixing the toolbar yourself is the wrong solution here. I changed the save icon toolbar (for layout in the case) via the Options->Toolbars:

and removed the enable condition. OK'd and then quit virtuoso and restarted. 

After that, the save icon is always enabled, even if the cellView is unmodified.

The problem is that if you open a cellview, make a change, save, undo that change and then try to save again, it still won't save because the underlying function doing the save (within leHiSave) doesn't do the save because it doesn't think the cellVIew is modified.

The issue is really that the handling of the modification status isn't quite correct at the moment when using undo past save. That's what needs to be fixed.

The best workaround is still to use a bindkey as in the article you referred to, as that will call dbSave() to do the same which forces a save whether it's needed or not.

Note if you make the change to the toolbar above, you can either use the "Reset" button in the bottom left to reset it, or delete the ~/.cadence/dfII/toolbars/byApplication/Layout.overlay file (if that was the toolbar you modified).

Regards,

Andrew

I did a little further experiment, and in fact this draws me to the conclusion that fixing the toolbar yourself is the wrong solution here. I changed the save icon toolbar (for layout in the case) via the Options->Toolbars:

and removed the enable condition. OK'd and then quit virtuoso and restarted. 

After that, the save icon is always enabled, even if the cellView is unmodified.

The problem is that if you open a cellview, make a change, save, undo that change and then try to save again, it still won't save because the underlying function doing the save (within leHiSave) doesn't do the save because it doesn't think the cellVIew is modified.

The issue is really that the handling of the modification status isn't quite correct at the moment when using undo past save. That's what needs to be fixed.

The best workaround is still to use a bindkey as in the article you referred to, as that will call dbSave() to do the same which forces a save whether it's needed or not.

Note if you make the change to the toolbar above, you can either use the "Reset" button in the bottom left to reset it, or delete the ~/.cadence/dfII/toolbars/byApplication/Layout.overlay file (if that was the toolbar you modified).

Regards,

Andrew