Less than operator (lessp, <) gives an error (containing srrWave keyword) inside a procedure

Your functions need to be able to handle families of waveforms as well as waveforms - at the moment, they don't. When plotting something in ADE, it will evaluate with the entire set of results for each signal, and so will see a family - your code needs to always cater for that. See this simple example to see the pattern. I've rewritten your two functions to do this, and used a for loop instead of while. It's also a good idea to create a new vector rather than overwriting the value in place as that can have unintended side effects.

I think these should work:

procedure( comparator(wave threshold)
  let((yVec newYVec)
    cond(
      (drIsWaveform(wave)
        yVec = drGetWaveformYVec(wave)
        newYVec = drCreateVec('double drVectorLength(yVec))
        for(i 0 drVectorLength(yVec)-1
          if( drGetElem(yVec i) < threshold then
            drSetElem(newYVec i 0)
          else
            drSetElem(newYVec i 1)
          );if
        );for
        drCreateWaveform(drGetWaveformXVec(wave) newYVec)
      )
      (famIsFamily(wave)
        famMap('comparator wave threshold)
      )
      (t
        error("comparator: cannot handle %L\n" wave)
      )
    )
  )
)

procedure( countOccurrence(wave yVal)
  let((yVec (count 0))
    cond(
      (drIsWaveform(wave)
        yVec = drGetWaveformYVec(wave)
        for(i 0 drVectorLength(yVec)-1
          when(nearlyEqual(drGetElem(yVec i) yVal)
            count++
          )
        )
        count
      )
      (famIsFamily(wave)
        famMap('countOccurrence wave yVal)
      )
      (t
        error("countOccurrence: cannot handle %L\n" wave)
      )
    )
  )
)

Andrew

Hi Andrew,

Thank you very much for your response. It worked and besides it was very educative.

Finally, I would like to learn if the way I wrote the code was efficient in terms of execution speed. More generally, are there ways and tricks to make the code run faster? For example, in Matlab, we usually try to avoid for loops and solve the problems using matrix operation. Does this (or something similar to this) also apply to SKILL? If this is the case, could you recommend a source where I can find further information?

Best regards,

Can

baltaci said:

Finally, I would like to learn if the way I wrote the code was efficient in terms of execution speed

There are a number of functions that already work on waveform objects and avoid the need to have to loop over each element to do something. However, in this case that can't be avoided. There isn't the same concept as having matrices and vectors which can be efficiently processed in SKILL (there are waveforms which many operators have been overloaded to handle, but not for every operation).

In general there's a section in the SKILL Language User Guide on Optimizing SKILL. I also talk a bit about it in my Writing Good SKILL Code (Video)

Andrew

baltaci said:

Finally, I would like to learn if the way I wrote the code was efficient in terms of execution speed

There are a number of functions that already work on waveform objects and avoid the need to have to loop over each element to do something. However, in this case that can't be avoided. There isn't the same concept as having matrices and vectors which can be efficiently processed in SKILL (there are waveforms which many operators have been overloaded to handle, but not for every operation).

In general there's a section in the SKILL Language User Guide on Optimizing SKILL. I also talk a bit about it in my Writing Good SKILL Code (Video)

Andrew

Hi Andrew,

Many thanks for the explanations and the link of the video.

Best regards,

Can