Stats

  • Locked Locked
  • Replies 2
  • Subscribers 65
  • Views 13513
  • Members are here 0
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Puzzled by definition of this struct

TaoZ

Hi, all

me again, I've read a definition of struct as follows:

-- Definition of the packet struct
struct packet {
    kind       : [good,bad];
    addr       : uint (bits : 2) ;
    len        : uint (bits : 6) ;
    data [len] : list of byte ;
    !parity    : byte ;
};

Here, is kind a enumerated type, as it may already be defined? 

Tao

Parents

  • This code isn't very good and should be avoided. The type of kind is an enumerated type, but the enum type is defined implicitly inline. This means we don't know what the type is called (some internally generated name). This makes it hard to reuse. I would recommend to define the enum type explicitly outside of the struct.

  • in reply to hannes

    Hi, Hannes

    Thanks for your reply!

    so it's better to write as follows?

    <'
    type packet_type: [GOOD,BAD];
    -- Definition of the packet struct
struct packet {
    kind       : packet_type;
    addr       : uint (bits : 2) ;
    len        : uint (bits : 6) ;
    data [len] : list of byte ;
    !parity    : byte ;
};
    '>

    Tao
Reply
  • in reply to hannes

    Hi, Hannes

    Thanks for your reply!

    so it's better to write as follows?

    <'
    type packet_type: [GOOD,BAD];
    -- Definition of the packet struct
struct packet {
    kind       : packet_type;
    addr       : uint (bits : 2) ;
    len        : uint (bits : 6) ;
    data [len] : list of byte ;
    !parity    : byte ;
};
    '>

    Tao
Children
No Data

Community Guidelines

The Cadence Design Communities support Cadence users and technologists interacting to exchange ideas, news, technical information, and best practices to solve problems and get the most from Cadence technology. The community is open to everyone, and to provide the most value, we require participants to follow our Community Guidelines that facilitate a quality exchange of ideas and information. By accessing, contributing, using or downloading any materials from the site, you agree to be bound by the full Community Guidelines.