skill code for placing components around circle (polar placement)

Hi Arumugam Petchi,

The code has got nice functionality for those designers needing polar placement. Good job

A few minor observations:

1. All your variables are global. This is bad practice in any language. Use the let statement and try to include all variables. If variables must be global, use a complex name that cannot conflict with other Skill and declare them using defvar.
2. I prefer to use embedded forms now they are available. It makes your Skill more robust. Check the documentation for axlFormCreate.
3. I think this form should not use the string option. Indeed I never user this as I think it's unnecessary with good coding.
4. Select symbol, Symbol angle and Direction fields could be outside the tabs as they are common to both. Indeed it doesn't really seem necessary to have two tabs. A "Circle" check box might be easier. Grey out the Start/End angle box when circle selected.
5. Direction (misspelled) could be a drop-down selection list
6. I suggest you add default values in your form for radius, angles and direction. Maybe you can store the values to pre-populate the form next time it is run (maybe the only excuse for using global variables or a design property).

Regards,

Dave

Hi Arumugam Petchi,

The code has got nice functionality for those designers needing polar placement. Good job

A few minor observations:

1. All your variables are global. This is bad practice in any language. Use the let statement and try to include all variables. If variables must be global, use a complex name that cannot conflict with other Skill and declare them using defvar.
2. I prefer to use embedded forms now they are available. It makes your Skill more robust. Check the documentation for axlFormCreate.
3. I think this form should not use the string option. Indeed I never user this as I think it's unnecessary with good coding.
4. Select symbol, Symbol angle and Direction fields could be outside the tabs as they are common to both. Indeed it doesn't really seem necessary to have two tabs. A "Circle" check box might be easier. Grey out the Start/End angle box when circle selected.
5. Direction (misspelled) could be a drop-down selection list
6. I suggest you add default values in your form for radius, angles and direction. Maybe you can store the values to pre-populate the form next time it is run (maybe the only excuse for using global variables or a design property).

Regards,

Dave